Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: non-consuming builder for Connection #708

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Conversation

swanandx
Copy link
Member

@swanandx swanandx commented Sep 5, 2023

Construct Connection using builder pattern to avoid passing too many arguments to Connection::new

Type of change

  • Miscellaneous (related to maintenance)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

Copy link

@h3nill h3nill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swanandx swanandx merged commit 27282a8 into main Sep 9, 2023
2 of 3 checks passed
@swanandx swanandx deleted the connection-constructor branch September 9, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants